diff options
| author | Jiri Slaby <jslaby@suse.cz> | 2012-08-13 10:18:09 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-08-13 16:57:58 -0700 |
| commit | a342ca1c78627c3a8b2a8c4e6d5f6ab1b88e6169 (patch) | |
| tree | 7004ec8bafe586bf93c0cf72a8e72f02652f8cb0 | |
| parent | 27bf7c43a19c66bdc96ee3ee5a67e3bc2d601736 (diff) | |
| download | linux-a342ca1c78627c3a8b2a8c4e6d5f6ab1b88e6169.tar.bz2 | |
TTY: mxser, fix invalid module_parm permissions
444 means 0674 and we do not definitely want that. Use S_IRUGO which
is much more safer.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-by: Rusty Russell <rusty@ozlabs.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/tty/mxser.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c index 8bc265154ad7..bb2da4ca8257 100644 --- a/drivers/tty/mxser.c +++ b/drivers/tty/mxser.c @@ -2338,7 +2338,7 @@ static struct tty_port_operations mxser_port_ops = { */ static bool allow_overlapping_vector; -module_param(allow_overlapping_vector, bool, 444); +module_param(allow_overlapping_vector, bool, S_IRUGO); MODULE_PARM_DESC(allow_overlapping_vector, "whether we allow ISA cards to be configured such that vector overlabs IO ports (default=no)"); static bool mxser_overlapping_vector(struct mxser_board *brd) |