summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Warren <swarren@nvidia.com>2012-04-30 17:24:10 -0600
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-05-01 14:11:51 -0400
commit04c235c92ce8474e9f2b358bd97f013a500385f2 (patch)
tree7c53d7ef6c8f8080dd250934cd6daaf042c653d1
parentebf20de453042c066a289b90dd14d59de03dba2f (diff)
downloadlinux-04c235c92ce8474e9f2b358bd97f013a500385f2.tar.bz2
USB: ehci-tegra: remove redundant gpio_set_value
The immediately preceding gpio_direction_output() already set the value, so there's no need to repeat it. This also prevents gpio_set_value() from WARNing when the GPIO is sleepable (e.g. is on an I2C expander); the set direction API is always sleepable, but plain set_value isn't. Cc: <stable@vger.kernel.org> # v3.3 Signed-off-by: Stephen Warren <swarren@nvidia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/host/ehci-tegra.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
index 73f3525e6921..f214a80cdee2 100644
--- a/drivers/usb/host/ehci-tegra.c
+++ b/drivers/usb/host/ehci-tegra.c
@@ -458,7 +458,6 @@ static int setup_vbus_gpio(struct platform_device *pdev)
dev_err(&pdev->dev, "can't enable vbus\n");
return err;
}
- gpio_set_value(gpio, 1);
return err;
}