diff options
| author | Vasiliy Kulikov <segooon@gmail.com> | 2010-09-28 21:08:08 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-09-30 04:14:21 -0700 |
| commit | 20caa14c59dfda3f4be75530e08e439ad2e73580 (patch) | |
| tree | aba31cedda266655e6e69ad45c67f17e900f9b25 | |
| parent | c4711c3acb9fbe7f559ead7ff511dba3665a048e (diff) | |
| download | linux-20caa14c59dfda3f4be75530e08e439ad2e73580.tar.bz2 | |
staging: slicoss: use free_netdev(netdev) instead of kfree()
Freeing netdev without free_netdev() leads to net, tx leaks.
I might lead to dereferencing freed pointer.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
@@
struct net_device* dev;
@@
-kfree(dev)
+free_netdev(dev)
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Acked-by: Denis Kirjanov <dkirjanov@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/staging/slicoss/slicoss.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 58ff1233270c..18f11039bb5f 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -3233,7 +3233,7 @@ static void __devexit slic_entry_remove(struct pci_dev *pcidev) slic_global.num_slic_cards--; slic_card_cleanup(card); } - kfree(dev); + free_netdev(dev); pci_release_regions(pcidev); } |