diff options
| author | Eric Dumazet <edumazet@google.com> | 2018-02-22 19:45:27 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-02-23 12:35:46 -0500 |
| commit | a5f7add332b4ea6d4b9480971b3b0f5e66466ae9 (patch) | |
| tree | ba06636322eaf68b2e210502fec48a8f7b6dd883 | |
| parent | 22170094437b4ae2308944bb3ec0fe7ebe45f4a1 (diff) | |
| download | linux-a5f7add332b4ea6d4b9480971b3b0f5e66466ae9.tar.bz2 | |
net_sched: gen_estimator: fix broken estimators based on percpu stats
pfifo_fast got percpu stats lately, uncovering a bug I introduced last
year in linux-4.10.
I missed the fact that we have to clear our temporary storage
before calling __gnet_stats_copy_basic() in the case of percpu stats.
Without this fix, rate estimators (tc qd replace dev xxx root est 1sec
4sec pfifo_fast) are utterly broken.
Fixes: 1c0d32fde5bd ("net_sched: gen_estimator: complete rewrite of rate estimators")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/core/gen_estimator.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/core/gen_estimator.c b/net/core/gen_estimator.c index 0a3f88f08727..98fd12721221 100644 --- a/net/core/gen_estimator.c +++ b/net/core/gen_estimator.c @@ -66,6 +66,7 @@ struct net_rate_estimator { static void est_fetch_counters(struct net_rate_estimator *e, struct gnet_stats_basic_packed *b) { + memset(b, 0, sizeof(*b)); if (e->stats_lock) spin_lock(e->stats_lock); |