summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLaurentiu Tudor <laurentiu.tudor@nxp.com>2017-06-27 17:41:21 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-06-29 16:38:52 +0200
commit714cc27d41b5676257e6b23851ff4afacf395883 (patch)
treeedb746288f105e8e332064968eb5622c7d646c7c
parentce73724d4d4f5f807ca0739b8993394ece9f4212 (diff)
downloadlinux-714cc27d41b5676257e6b23851ff4afacf395883.tar.bz2
staging: fsl-mc: move comparison before strcmp() call
Move comparison before the strcmp() in this if statement, and slightly increase efficiency by not making the strcmp() each time the if gets evaluated but only when the comparison is true. This was suggested in a review comment. Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/fsl-mc/bus/dprc-driver.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
index 80c080f20da1..1765e2ddba11 100644
--- a/drivers/staging/fsl-mc/bus/dprc-driver.c
+++ b/drivers/staging/fsl-mc/bus/dprc-driver.c
@@ -29,8 +29,9 @@ struct dprc_child_objs {
static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev,
struct dprc_obj_desc *obj_desc)
{
- return !strcmp(mc_dev->obj_desc.type, obj_desc->type) &&
- mc_dev->obj_desc.id == obj_desc->id;
+ return mc_dev->obj_desc.id == obj_desc->id &&
+ !strcmp(mc_dev->obj_desc.type, obj_desc->type);
+
}
static int __fsl_mc_device_remove_if_not_in_mc(struct device *dev, void *data)