fix warnings

 * fix signess (guint32 -> gint32)
 * remove some unused variables
 * add <epan/expert.h> as needed
 * include handler.h in isi-packet.c

1 files changed, 33 insertions, 34 deletions

diff --git a/src/isi-gps.c b/src/isi-gps.c
index 3ed3787..8a2c8aa 100644
--- a/src/isi-gps.c
+++ b/src/isi-gps.c
@@ -70,39 +70,39 @@ static const value_string isi_gps_status[] = {
 static dissector_handle_t isi_gps_handle;
 static void dissect_isi_gps(tvbuff_t *tvb, packet_info *pinfo, proto_item *tree);
 
-static guint32 hf_isi_gps_cmd = -1;
-static guint32 hf_isi_gps_sub_pkgs = -1;
-static guint32 hf_isi_gps_sub_type = -1;
-static guint32 hf_isi_gps_sub_len = -1;
-static guint32 hf_isi_gps_status = -1;
-static guint32 hf_isi_gps_year = -1;
-static guint32 hf_isi_gps_month = -1;
-static guint32 hf_isi_gps_day = -1;
-static guint32 hf_isi_gps_hour = -1;
-static guint32 hf_isi_gps_minute = -1;
-static guint32 hf_isi_gps_second = -1;
-static guint32 hf_isi_gps_latitude = -1;
-static guint32 hf_isi_gps_longitude = -1;
-static guint32 hf_isi_gps_eph = -1;
-static guint32 hf_isi_gps_altitude = -1;
-static guint32 hf_isi_gps_epv = -1;
-static guint32 hf_isi_gps_course = -1;
-static guint32 hf_isi_gps_epd = -1;
-static guint32 hf_isi_gps_speed = -1;
-static guint32 hf_isi_gps_eps = -1;
-static guint32 hf_isi_gps_climb = -1;
-static guint32 hf_isi_gps_epc = -1;
-static guint32 hf_isi_gps_mcc = -1;
-static guint32 hf_isi_gps_mnc = -1;
-static guint32 hf_isi_gps_lac = -1;
-static guint32 hf_isi_gps_cid = -1;
-static guint32 hf_isi_gps_ucid = -1;
-static guint32 hf_isi_gps_satellites = -1;
-static guint32 hf_isi_gps_prn = -1;
-static guint32 hf_isi_gps_sat_used = -1;
-static guint32 hf_isi_gps_sat_strength = -1;
-static guint32 hf_isi_gps_sat_elevation = -1;
-static guint32 hf_isi_gps_sat_azimuth = -1;
+static gint32 hf_isi_gps_cmd = -1;
+static gint32 hf_isi_gps_sub_pkgs = -1;
+static gint32 hf_isi_gps_sub_type = -1;
+static gint32 hf_isi_gps_sub_len = -1;
+static gint32 hf_isi_gps_status = -1;
+static gint32 hf_isi_gps_year = -1;
+static gint32 hf_isi_gps_month = -1;
+static gint32 hf_isi_gps_day = -1;
+static gint32 hf_isi_gps_hour = -1;
+static gint32 hf_isi_gps_minute = -1;
+static gint32 hf_isi_gps_second = -1;
+static gint32 hf_isi_gps_latitude = -1;
+static gint32 hf_isi_gps_longitude = -1;
+static gint32 hf_isi_gps_eph = -1;
+static gint32 hf_isi_gps_altitude = -1;
+static gint32 hf_isi_gps_epv = -1;
+static gint32 hf_isi_gps_course = -1;
+static gint32 hf_isi_gps_epd = -1;
+static gint32 hf_isi_gps_speed = -1;
+static gint32 hf_isi_gps_eps = -1;
+static gint32 hf_isi_gps_climb = -1;
+static gint32 hf_isi_gps_epc = -1;
+static gint32 hf_isi_gps_mcc = -1;
+static gint32 hf_isi_gps_mnc = -1;
+static gint32 hf_isi_gps_lac = -1;
+static gint32 hf_isi_gps_cid = -1;
+static gint32 hf_isi_gps_ucid = -1;
+static gint32 hf_isi_gps_satellites = -1;
+static gint32 hf_isi_gps_prn = -1;
+static gint32 hf_isi_gps_sat_used = -1;
+static gint32 hf_isi_gps_sat_strength = -1;
+static gint32 hf_isi_gps_sat_elevation = -1;
+static gint32 hf_isi_gps_sat_azimuth = -1;
 
 void proto_reg_handoff_isi_gps(void) {
 	static gboolean initialized=FALSE;
@@ -188,7 +188,6 @@ void proto_register_isi_gps(void) {
 }
 
 static void dissect_isi_gps_data(tvbuff_t *tvb, packet_info *pinfo, proto_item *item, proto_tree *tree) {
-	guint8 len = tvb->length;
 	int i;
 
 	guint8 pkgcount = tvb_get_guint8(tvb, 0x07);