diff options
| author | Paul Kocialkowski <paul.kocialkowski@bootlin.com> | 2022-12-08 15:20:02 +0100 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2022-12-14 18:12:31 +0000 |
| commit | f72af770947825cd9947ce8b979bf9d6fe699c73 (patch) | |
| tree | 863566c98caddccaadc3a2f994b4f8b806e5b51c /drivers/staging | |
| parent | 504307f2b3ae2625ed591efe073c2d14d568dfc8 (diff) | |
| download | linux-f72af770947825cd9947ce8b979bf9d6fe699c73.tar.bz2 | |
media: sun6i-isp: proc: Error out on invalid port to fix warning
The enabled variable is only set for a valid port and used later,
which triggers an uninitialized use smatch warning. Explicitly error
out in that case to fix the warning.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Fixes: e3185e1d7c14 ("media: staging: media: Add support for the Allwinner A31 ISP")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c index a95709d2c573..4f34c1bc8be9 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c @@ -416,7 +416,7 @@ static int sun6i_isp_proc_notifier_bound(struct v4l2_async_notifier *notifier, enabled = !proc->source_csi0.expected; break; default: - break; + return -EINVAL; } source->subdev = remote_subdev; |