From 3cb6e1c90b8f361c19bfb5c5315eebbc56650e1c Mon Sep 17 00:00:00 2001 From: Andrzej Zaborowski Date: Tue, 4 Aug 2009 05:39:40 +0200 Subject: Fix invalid queue use in sim_write_cb Since we pop the queue's head, we can't use sim_op_error --- src/sim.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'src/sim.c') diff --git a/src/sim.c b/src/sim.c index d432e1ba..e557b1f0 100644 --- a/src/sim.c +++ b/src/sim.c @@ -482,12 +482,10 @@ static void sim_op_write_cb(const struct ofono_error *error, void *data) struct sim_file_op *op = g_queue_pop_head(sim->simop_q); ofono_sim_file_write_cb_t cb = op->cb; - if (error->type != OFONO_ERROR_TYPE_NO_ERROR) { - sim_op_error(modem); - return; - } - - cb(modem, 1, op->userdata); + if (error->type == OFONO_ERROR_TYPE_NO_ERROR) + cb(modem, 1, op->userdata); + else + cb(modem, 0, op->userdata); sim_file_op_free(op); -- cgit v1.2.3