From e0c8704705fa6a4fba8c3fd29361b0fab27a8ba1 Mon Sep 17 00:00:00 2001 From: Denis Kenzior Date: Tue, 6 Apr 2010 17:39:16 -0500 Subject: ppp: Verify magic number is not zero --- gatchat/ppp_lcp.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'gatchat/ppp_lcp.c') diff --git a/gatchat/ppp_lcp.c b/gatchat/ppp_lcp.c index 81182ba1..3faf3ac7 100644 --- a/gatchat/ppp_lcp.c +++ b/gatchat/ppp_lcp.c @@ -105,10 +105,19 @@ static guint lcp_option_scan(struct pppcp_data *pppcp, case ACCM: case AUTH_PROTO: /* XXX check to make sure it's a proto we recognize */ - case MAGIC_NUMBER: case PFC: case ACFC: return OPTION_ACCEPT; + + case MAGIC_NUMBER: + { + guint32 magic = get_host_long(option->data); + + if (magic == 0) + return OPTION_REJECT; + + return OPTION_ACCEPT; + } } return OPTION_REJECT; -- cgit v1.2.3