summaryrefslogtreecommitdiffstats
path: root/include
AgeCommit message (Collapse)AuthorFilesLines
2009-09-10Fix cut-paste errorDenis Kenzior1-1/+1
2009-09-10Add initial Cell Broadcast atom implementationDenis Kenzior1-0/+65
2009-09-08Add modem properties for booleansMarcel Holtmann1-0/+6
2009-09-02Get rid of node argument in ofono_modem_createDenis Kenzior1-1/+1
2009-09-02Add modem property capabilityDenis Kenzior1-0/+8
Add ofono_modem_set_string & ofono_modem_get_string Add ofono_modem_set_integer & ofono_modem_get_integer
2009-09-01populate should return voidDenis Kenzior1-1/+1
2009-09-01Make remove functions not return anythingDenis Kenzior13-13/+13
2009-09-01change int vendor to unsigned int vendorDenis Kenzior12-25/+39
2009-09-01Add vendor flag capability to voicecallsDenis Kenzior1-1/+2
2009-09-01Add vendor flag capability to ussdDenis Kenzior1-2/+2
2009-09-01Add vendor flag capability to ssnDenis Kenzior1-2/+2
2009-09-01Add vendor flag capability for smsDenis Kenzior1-2/+2
2009-09-01Add vendor flag capability to simDenis Kenzior1-2/+2
2009-09-01Add vendor flag capability to phonebookDenis Kenzior1-1/+2
2009-09-01Add vendor flag capability to netregDenis Kenzior1-2/+2
2009-09-01Add vendor flag capability to devinfoDenis Kenzior1-1/+2
2009-09-01Add vendor flag to call-settingsDenis Kenzior1-1/+2
2009-09-01Add vendor parameter to call-meterDenis Kenzior1-1/+2
2009-09-01Add vendor flag to call-forwardingDenis Kenzior1-1/+2
2009-09-01Introduce vendor parameter to call-barringDenis Kenzior1-1/+2
2009-08-31Expose service dialling numbers stored on SIM through SimManager.Andrzej Zaborowski1-0/+9
2009-08-30Reformat comments a littleDenis Kenzior1-6/+8
2009-08-30driver callback namingAndres Salomon1-0/+9
On Sun, 30 Aug 2009 13:45:45 -0500 Denis Kenzior <denkenz@gmail.com> wrote: > Hi Andres, > > > static struct ofono_modem_driver g1_driver = { > > .name = "HTC G1", > > .probe = g1_probe, > > .enable = g1_enable, > > .disable = g1_disable, > > .remove = g1_remove, > > .populate = g1_populate, > > }; > > > > So the current intention: > .probe - Detect whether device is really supported by the plugin, > initialize any data structures specific to the device > .remove - Destroy data structures > .enable - Perform power up > .disable - Perform power down > .populate - Populate the atoms supported by this device (e.g. netreg, > voicecall, etc) This is called by the core after every power cycle, > when the device is brought up. > Thanks! See patch below. > > > > Of course, I'm also wondering why there needs to be two separate > > layers of calls in the first place. Why not have drivers register > > everything from within probe, call ofono_set_powered(modem, TRUE) > > once the device is ready, and be done with it? > > The reason for this is e.g. airplane mode, where you physically want > to turn off the device. Another case is for battery / power reasons, > e.g. a netbook with a USB modem that is not being used. > Fair enough. In the kernel, we have callbacks named suspend/resume to handle that. > > The only reason why this doesn't blow up in the generic_at plugin is > > because the driver_data is leaked. If one were to free it from > > generic_at_exit in the wrong place (since it's allocated from > > generic_at_init, it would make sense to free it in generic_at_exit), > > one would see the same SEGV/SIGBUS/SIGILL errors upon ctrl-c. > > So the leak has now been fixed. > > I think you're being unnecessarily harsh here. To be fair, the > generic_at driver does something like this at init: My criticism is simply w/ the naming. 'enable'/'disable' doesn't imply anything about power. powerup/powerdown, poweron/poweroff, suspend/resume would all imply power state changes (at least the latter would be familiar to those who do kernel stuff). Having comments that describe what the callbacks do would also work, though. >From 80a7b54d52201dfd7d8b590457450ae0a4f72888 Mon Sep 17 00:00:00 2001 From: Andres Salomon <dilinger@collabora.co.uk> Date: Sun, 30 Aug 2009 15:56:16 -0400 Subject: [PATCH] Add comments to ofono_modem_driver struct Document what all the callbacks do.
2009-08-24Convert to fully non-recursive build systemMarcel Holtmann1-26/+0
2009-08-24Fix broken dependency on include/ofono/*.h filesRémi Denis-Courmont1-7/+9
The fact that the directory exists does not prove that (all of) the header file symbolic links have been created. This is particularly annoying when a new header file gets added.
2009-08-21Introduce the Modem driver APIDenis Kenzior2-2/+30
2009-08-20Rename ofono_modem_*_userdataDenis Kenzior1-2/+2
Rename ofono_modem_get_userdata to ofono_modem_get_data Rename ofono_modem_set_userdata to ofono_modem_set_data For consistency with other drivers
2009-08-20Break out device info into a separate driverDenis Kenzior3-1/+70
The modem info ops (Serial, Manufacturer, etc) are broken into a separate oFono atom. This is mainly to support a proper modem device driver infrastructure. As a result the data structures have been tweaked a little. driver.h is now empty and has been removed.
2009-08-19Evolve the voicecall driverDenis Kenzior3-1/+125
2009-08-19Evolve the netreg driverDenis Kenzior2-1/+114
2009-08-19Move mcc & mnc defines to types.hDenis Kenzior1-0/+4
2009-08-19Evolve message waiting low level APIDenis Kenzior2-1/+42
2009-08-19Evolve SIM driverDenis Kenzior2-1/+137
2009-08-19Move ofono_destroy_fun to types.hDenis Kenzior1-0/+2
2009-08-19Evolve SMS driver APIDenis Kenzior2-1/+77
2009-08-17Evolve the USSD APIDenis Kenzior2-1/+64
2009-08-14Refactor cssn into ofono_ssnDenis Kenzior2-1/+62
Make this into a fully fledged entity, with a driver instead of the current kludge. This means modem drivers can actually choose whether to instantiate a CSSN atom or not Move the notification functions from voicecall.c into ssn.c. Move the cssn.h header into include/ssn.h and refactor Update call barring to utilize ofono_ssn and use the new atom_watch functionality to detect when ssn has been added or removed
2009-08-14Move CALL_SETTINGS_INTERFACE define to dbus.hDenis Kenzior1-0/+1
2009-08-14Move PHONEBOOK_INTERFACE define to dbus.hDenis Kenzior1-0/+1
2009-08-14Move CALL_METER_INTERFACE define to dbus.hDenis Kenzior1-1/+1
2009-08-14Move CALL_FORWARDING_INTERFACE define to dbus.hDenis Kenzior1-0/+2
2009-08-14Move CALL_BARRING_INTERFACE definition to dbus.hDenis Kenzior1-0/+1
2009-08-14Evolve the phonebook driverDenis Kenzior2-1/+73
2009-08-14Evolve call settings driverDenis Kenzior2-1/+80
2009-08-14Move clir and cug option enums to types.hDenis Kenzior1-0/+13
2009-08-14Evolve the call meter driver APIDenis Kenzior2-1/+88
2009-08-14Evolve the call-forwarding driverDenis Kenzior2-1/+89
2009-08-14Evolve the call-barring driverDenis Kenzior2-1/+70
- Move call barring related functionality out of driver.h into a dedicated file, call-barring.h - Update to use the new atom framework - Remove over-reliance on the modem structure, call-barring structure should now be used instead whenever possible
2009-08-13Move certain parts of driver.h to types.hDenis Kenzior2-1/+55
2009-08-12Add function for printing warningsMarcel Holtmann1-0/+2
generated by cgit v1.2.3 (git 2.39.1) at 2025-07-09 06:02:03 +0000