Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2013-02-14 | include: Add ofono_modem_find | Denis Kenzior | 1 | -0/+6 | |
2012-11-02 | include: Add TEST modem type | Denis Kenzior | 1 | -0/+1 | |
2012-06-16 | modem: Conform to coding style item M9 | Denis Kenzior | 1 | -34/+34 | |
2012-06-17 | modem: Add function for setting new driver type | Marcel Holtmann | 1 | -0/+1 | |
2011-11-22 | include: Add modem type to modem.h | Daniel Wagner | 1 | -0/+7 | |
2011-10-10 | core: Update copyright information | Marcel Holtmann | 1 | -1/+1 | |
2011-04-04 | include: add ofono_modem_get_emergency_mode api | Jeevaka Badrappan | 1 | -0/+2 | |
2010-12-07 | modem: add ofono_modem_reset() to modem.h | Gustavo F. Padovan | 1 | -0/+2 | |
2010-10-25 | modem: Add ofono_modem_is_registered | Denis Kenzior | 1 | -0/+2 | |
2010-08-12 | modem: Be consistent when naming callback typedefs | Denis Kenzior | 1 | -2/+2 | |
2010-06-09 | Add support for Features property on modem interface | Marcel Holtmann | 1 | -1/+0 | |
2010-05-27 | Use ofono_bool_t instead of bool in modem API. | Pekka Pessi | 1 | -4/+3 | |
2010-05-26 | Fix: minor style issues | Denis Kenzior | 1 | -2/+2 | |
2010-05-26 | Add: Online property to modem | Pekka Pessi | 1 | -0/+12 | |
The online/offline state is changed with the new set_online() modem driver method. In order to track atoms, there are modem states as follows: - OFONO_MODEM_STATE_POWER_OFF - OFONO_MODEM_STATE_PRE_SIM - OFONO_MODEM_STATE_OFFLINE - OFONO_MODEM_STATE_ONLINE Atoms are added with driver methods pre_sim(), post_sim() and post_online(). Atoms are removed by modem core when the state changes. | |||||
2010-02-12 | Add support for modem names | Denis Kenzior | 1 | -0/+2 | |
2010-01-06 | Refactor: Allow persisent modem names | Denis Kenzior | 1 | -1/+1 | |
2010-01-01 | Update copyright information | Marcel Holtmann | 1 | -1/+1 | |
2009-09-17 | Split populate modem driver method | Denis Kenzior | 1 | -2/+5 | |
Introduce two new methods - pre_sim - SIM is not inserted or locked. This should populate the modem with atoms that can be used without the SIM. Generally this is the devinfo atom, the sim atom and the voice call atom (emergency calls only) - post_sim - SIM is ready. This method should populate the modem with the remaining atoms | |||||
2009-09-08 | Add modem properties for booleans | Marcel Holtmann | 1 | -0/+6 | |
2009-09-02 | Get rid of node argument in ofono_modem_create | Denis Kenzior | 1 | -1/+1 | |
2009-09-02 | Add modem property capability | Denis Kenzior | 1 | -0/+8 | |
Add ofono_modem_set_string & ofono_modem_get_string Add ofono_modem_set_integer & ofono_modem_get_integer | |||||
2009-09-01 | populate should return void | Denis Kenzior | 1 | -1/+1 | |
2009-09-01 | Make remove functions not return anything | Denis Kenzior | 1 | -1/+1 | |
2009-08-30 | Reformat comments a little | Denis Kenzior | 1 | -6/+8 | |
2009-08-30 | driver callback naming | Andres Salomon | 1 | -0/+9 | |
On Sun, 30 Aug 2009 13:45:45 -0500 Denis Kenzior <denkenz@gmail.com> wrote: > Hi Andres, > > > static struct ofono_modem_driver g1_driver = { > > .name = "HTC G1", > > .probe = g1_probe, > > .enable = g1_enable, > > .disable = g1_disable, > > .remove = g1_remove, > > .populate = g1_populate, > > }; > > > > So the current intention: > .probe - Detect whether device is really supported by the plugin, > initialize any data structures specific to the device > .remove - Destroy data structures > .enable - Perform power up > .disable - Perform power down > .populate - Populate the atoms supported by this device (e.g. netreg, > voicecall, etc) This is called by the core after every power cycle, > when the device is brought up. > Thanks! See patch below. > > > > Of course, I'm also wondering why there needs to be two separate > > layers of calls in the first place. Why not have drivers register > > everything from within probe, call ofono_set_powered(modem, TRUE) > > once the device is ready, and be done with it? > > The reason for this is e.g. airplane mode, where you physically want > to turn off the device. Another case is for battery / power reasons, > e.g. a netbook with a USB modem that is not being used. > Fair enough. In the kernel, we have callbacks named suspend/resume to handle that. > > The only reason why this doesn't blow up in the generic_at plugin is > > because the driver_data is leaked. If one were to free it from > > generic_at_exit in the wrong place (since it's allocated from > > generic_at_init, it would make sense to free it in generic_at_exit), > > one would see the same SEGV/SIGBUS/SIGILL errors upon ctrl-c. > > So the leak has now been fixed. > > I think you're being unnecessarily harsh here. To be fair, the > generic_at driver does something like this at init: My criticism is simply w/ the naming. 'enable'/'disable' doesn't imply anything about power. powerup/powerdown, poweron/poweroff, suspend/resume would all imply power state changes (at least the latter would be familiar to those who do kernel stuff). Having comments that describe what the callbacks do would also work, though. >From 80a7b54d52201dfd7d8b590457450ae0a4f72888 Mon Sep 17 00:00:00 2001 From: Andres Salomon <dilinger@collabora.co.uk> Date: Sun, 30 Aug 2009 15:56:16 -0400 Subject: [PATCH] Add comments to ofono_modem_driver struct Document what all the callbacks do. | |||||
2009-08-21 | Introduce the Modem driver API | Denis Kenzior | 1 | -2/+20 | |
2009-08-20 | Rename ofono_modem_*_userdata | Denis Kenzior | 1 | -2/+2 | |
Rename ofono_modem_get_userdata to ofono_modem_get_data Rename ofono_modem_set_userdata to ofono_modem_set_data For consistency with other drivers | |||||
2009-08-20 | Break out device info into a separate driver | Denis Kenzior | 1 | -0/+3 | |
The modem info ops (Serial, Manufacturer, etc) are broken into a separate oFono atom. This is mainly to support a proper modem device driver infrastructure. As a result the data structures have been tweaked a little. driver.h is now empty and has been removed. | |||||
2009-07-29 | Rename ofono_modem_userdata | Denis Kenzior | 1 | -0/+5 | |
2009-07-29 | Make plugins use ofono_modem_get_path | Denis Kenzior | 1 | -0/+2 | |
2009-07-29 | Rename modem_add_interface / modem_remove_interface | Denis Kenzior | 1 | -0/+39 | |
Move to ofono_modem_add_interface, ofono_modem_remove_interface and put in ofono/modem.h |