| Age | Commit message (Collapse) | Author | Files | Lines | |
|---|---|---|---|---|---|
| 2009-09-01 | Rename isi drivers to isimodem | Denis Kenzior | 13 | -26/+26 | |
| Be more consistent with directory naming | |||||
| 2009-09-01 | Rename generic_at drivers to atmodem | Denis Kenzior | 13 | -24/+24 | |
| Be more consistent with directory naming | |||||
| 2009-09-01 | populate should return void | Denis Kenzior | 3 | -7/+3 | |
| 2009-09-01 | Make remove functions not return anything | Denis Kenzior | 39 | -82/+39 | |
| 2009-09-01 | change int vendor to unsigned int vendor | Denis Kenzior | 48 | -67/+94 | |
| 2009-09-01 | Add first steps for a udev based modem detection plugin | Marcel Holtmann | 2 | -0/+76 | |
| 2009-09-01 | Update D-Bus configuration options and check for udev | Marcel Holtmann | 1 | -15/+40 | |
| 2009-09-01 | Add ofono_modem_get_powered | Denis Kenzior | 1 | -0/+8 | |
| 2009-09-01 | Add proposed data connection manager API | Denis Kenzior | 1 | -0/+163 | |
| 2009-09-01 | Add stub vendor.h file | Denis Kenzior | 1 | -0/+24 | |
| 2009-09-01 | Add vendor flag capability to voicecalls | Denis Kenzior | 6 | -11/+14 | |
| 2009-09-01 | Add vendor flag capability to ussd | Denis Kenzior | 6 | -9/+12 | |
| 2009-09-01 | Add vendor flag capability to ssn | Denis Kenzior | 6 | -9/+12 | |
| 2009-09-01 | Add vendor flag capability for sms | Denis Kenzior | 6 | -10/+12 | |
| 2009-09-01 | Add vendor flag capability to sim | Denis Kenzior | 6 | -9/+12 | |
| 2009-09-01 | Add vendor flag capability to phonebook | Denis Kenzior | 6 | -9/+12 | |
| 2009-09-01 | Add vendor flag capability to netreg | Denis Kenzior | 6 | -17/+16 | |
| 2009-09-01 | Add vendor flag capability to devinfo | Denis Kenzior | 6 | -10/+13 | |
| 2009-09-01 | Add vendor flag to call-settings | Denis Kenzior | 6 | -9/+18 | |
| 2009-09-01 | Add vendor parameter to call-meter | Denis Kenzior | 6 | -9/+13 | |
| 2009-09-01 | Add vendor flag to call-forwarding | Denis Kenzior | 6 | -9/+17 | |
| 2009-09-01 | Introduce vendor parameter to call-barring | Denis Kenzior | 6 | -9/+16 | |
| 2009-09-01 | gisi: Getter function for pipe handle | Ismo Puustinen | 2 | -0/+12 | |
| 2009-08-31 | Fix being able to set powered after failure | Denis Kenzior | 1 | -1/+4 | |
| If enable failed, subsequent attempts will also fail. | |||||
| 2009-08-31 | Add PDU listing support | Denis Kenzior | 2 | -17/+79 | |
| 2009-08-31 | Don't return sdn numbers until ready | Denis Kenzior | 1 | -1/+3 | |
| 2009-08-31 | Simplify EFsdn reading code | Denis Kenzior | 1 | -25/+28 | |
| 2009-08-31 | Rename MNCLength to MobileNetworkCodeLength | Denis Kenzior | 1 | -3/+3 | |
| 2009-08-31 | Refactor sim mnc length | Denis Kenzior | 1 | -7/+8 | |
| 2009-08-31 | Style Fix | Denis Kenzior | 1 | -4/+2 | |
| 2009-08-31 | Simplify nested ifs | Denis Kenzior | 1 | -15/+15 | |
| 2009-08-31 | Simplify overly complicated code | Denis Kenzior | 1 | -16/+16 | |
| 2009-08-31 | Expose service dialling numbers stored on SIM through SimManager. | Andrzej Zaborowski | 4 | -7/+227 | |
| 2009-08-31 | Decode and encode alpha-identifier fields | Andrzej Zaborowski | 4 | -11/+46 | |
| Add identifier argument to sim_adn_parse and sim_adn_build. Also fix the number length passed to extract_bcd_number in sim_adn_parse. | |||||
| 2009-08-31 | Read EFad and expose the IMSI MNC length (2-3) | Andrzej Zaborowski | 2 | -0/+45 | |
| 2009-08-30 | Reformat comments a little | Denis Kenzior | 1 | -6/+8 | |
| 2009-08-30 | driver callback naming | Andres Salomon | 1 | -0/+9 | |
| On Sun, 30 Aug 2009 13:45:45 -0500 Denis Kenzior <denkenz@gmail.com> wrote: > Hi Andres, > > > static struct ofono_modem_driver g1_driver = { > > .name = "HTC G1", > > .probe = g1_probe, > > .enable = g1_enable, > > .disable = g1_disable, > > .remove = g1_remove, > > .populate = g1_populate, > > }; > > > > So the current intention: > .probe - Detect whether device is really supported by the plugin, > initialize any data structures specific to the device > .remove - Destroy data structures > .enable - Perform power up > .disable - Perform power down > .populate - Populate the atoms supported by this device (e.g. netreg, > voicecall, etc) This is called by the core after every power cycle, > when the device is brought up. > Thanks! See patch below. > > > > Of course, I'm also wondering why there needs to be two separate > > layers of calls in the first place. Why not have drivers register > > everything from within probe, call ofono_set_powered(modem, TRUE) > > once the device is ready, and be done with it? > > The reason for this is e.g. airplane mode, where you physically want > to turn off the device. Another case is for battery / power reasons, > e.g. a netbook with a USB modem that is not being used. > Fair enough. In the kernel, we have callbacks named suspend/resume to handle that. > > The only reason why this doesn't blow up in the generic_at plugin is > > because the driver_data is leaked. If one were to free it from > > generic_at_exit in the wrong place (since it's allocated from > > generic_at_init, it would make sense to free it in generic_at_exit), > > one would see the same SEGV/SIGBUS/SIGILL errors upon ctrl-c. > > So the leak has now been fixed. > > I think you're being unnecessarily harsh here. To be fair, the > generic_at driver does something like this at init: My criticism is simply w/ the naming. 'enable'/'disable' doesn't imply anything about power. powerup/powerdown, poweron/poweroff, suspend/resume would all imply power state changes (at least the latter would be familiar to those who do kernel stuff). Having comments that describe what the callbacks do would also work, though. >From 80a7b54d52201dfd7d8b590457450ae0a4f72888 Mon Sep 17 00:00:00 2001 From: Andres Salomon <dilinger@collabora.co.uk> Date: Sun, 30 Aug 2009 15:56:16 -0400 Subject: [PATCH] Add comments to ofono_modem_driver struct Document what all the callbacks do. | |||||
| 2009-08-30 | Fix memory leak in generic_at driver | Denis Kenzior | 1 | -0/+6 | |
| 2009-08-30 | Add debug to modem_create | Denis Kenzior | 1 | -0/+2 | |
| 2009-08-29 | Make history drivers work again | Denis Kenzior | 1 | -3/+7 | |
| 2009-08-29 | Fix a problem with CtrlZ echo | Denis Kenzior | 1 | -0/+10 | |
| When a PDU is submitted and echoed by the modem, the CtrlZ character is also echoed back. Fix the parser to handle this case appropriately. | |||||
| 2009-08-28 | gisi: return GPRS interface index/name | Rémi Denis-Courmont | 2 | -6/+28 | |
| 2009-08-25 | gisi: Fix indication debugging | Aki Niemi | 1 | -3/+10 | |
| 2009-08-25 | Rename all files under drivers/isimodem/ | Aki Niemi | 13 | -12/+12 | |
| 2009-08-25 | Fix typo in technology name | Aki Niemi | 1 | -1/+1 | |
| 2009-08-24 | Convert to fully non-recursive build system | Marcel Holtmann | 30 | -366/+216 | |
| 2009-08-24 | Use script to generate list of builtin plugin symbols | Marcel Holtmann | 4 | -19/+24 | |
| 2009-08-24 | Use proper variables for various commands | Marcel Holtmann | 4 | -6/+14 | |
| 2009-08-24 | Add straw-man for rest of ISI modem driver | Aki Niemi | 13 | -1/+1580 | |
| 2009-08-24 | Fix broken dependency on include/ofono/*.h files | Rémi Denis-Courmont | 1 | -7/+9 | |
| The fact that the directory exists does not prove that (all of) the header file symbolic links have been created. This is particularly annoying when a new header file gets added. | |||||
 |
index : ofono | |
| Ofono | Ofono Group |
| summaryrefslogtreecommitdiffstats |