summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--gatchat/gatppp.c1
-rw-r--r--gatchat/ppp_auth.c2
-rw-r--r--gatchat/ppp_lcp.c6
3 files changed, 6 insertions, 3 deletions
diff --git a/gatchat/gatppp.c b/gatchat/gatppp.c
index 2462e7b5..74bd2658 100644
--- a/gatchat/gatppp.c
+++ b/gatchat/gatppp.c
@@ -437,6 +437,7 @@ void ppp_generate_event(GAtPPP *ppp, enum ppp_event event)
ppp_transition_phase(ppp, PPP_DEAD);
else if (ppp->phase == PPP_AUTHENTICATION)
ppp_transition_phase(ppp, PPP_TERMINATION);
+ break;
}
}
diff --git a/gatchat/ppp_auth.c b/gatchat/ppp_auth.c
index b2e08b2b..78cde4b8 100644
--- a/gatchat/ppp_auth.c
+++ b/gatchat/ppp_auth.c
@@ -189,6 +189,7 @@ static struct chap_data *chap_new(struct auth_data *auth, guint8 method)
break;
default:
g_print("Unknown method\n");
+ break;
}
/* register packet handler for CHAP protocol */
@@ -208,6 +209,7 @@ void auth_set_proto(struct auth_data *data, guint16 proto, guint8 method)
break;
default:
g_print("Unknown auth protocol 0x%x\n", proto);
+ break;
}
}
diff --git a/gatchat/ppp_lcp.c b/gatchat/ppp_lcp.c
index e09ed6b4..75ec6196 100644
--- a/gatchat/ppp_lcp.c
+++ b/gatchat/ppp_lcp.c
@@ -108,10 +108,9 @@ static guint lcp_option_scan(struct ppp_option *option, gpointer user)
case PFC:
case ACFC:
return OPTION_ACCEPT;
- break;
- default:
- return OPTION_REJECT;
}
+
+ return OPTION_REJECT;
}
/*
@@ -150,6 +149,7 @@ static void lcp_option_process(gpointer data, gpointer user)
break;
default:
g_printerr("unhandled option %d\n", option->type);
+ break;
}
}