diff options
| author | Denis Kenzior <denkenz@gmail.com> | 2009-12-08 04:24:38 -0600 |
|---|---|---|
| committer | Denis Kenzior <denkenz@gmail.com> | 2009-12-08 04:24:38 -0600 |
| commit | 430e8755dcd0f634ab70c571ba03c56696a4c58e (patch) | |
| tree | c8b96e7b7ff180819b442af1b06967a12fafdc1d /src | |
| parent | 06d17397c5c9c760b6da5a978a1d94dab05722aa (diff) | |
| download | ofono-430e8755dcd0f634ab70c571ba03c56696a4c58e.tar.bz2 | |
Fix: Print a warning in set_powered
If ofono_modem_set_powered is used with no driver set, print a warning
Diffstat (limited to 'src')
| -rw-r--r-- | src/modem.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/src/modem.c b/src/modem.c index 00ee04de..38467d2b 100644 --- a/src/modem.c +++ b/src/modem.c @@ -567,16 +567,20 @@ void ofono_modem_set_powered(struct ofono_modem *modem, ofono_bool_t powered) modem->powered_pending = powered; if (modem->powered != powered) { + dbus_bool_t dbus_powered = powered; modem->powered = powered; - if (modem->driver) { - dbus_bool_t dbus_powered = powered; + if (modem->driver == NULL) { + ofono_error("Calling ofono_modem_set_powered on a" + "modem with no driver is not valid, " + "please fix the modem driver."); + return; + } - ofono_dbus_signal_property_changed(conn, modem->path, + ofono_dbus_signal_property_changed(conn, modem->path, OFONO_MODEM_INTERFACE, "Powered", DBUS_TYPE_BOOLEAN, &dbus_powered); - } if (powered) { if (modem->driver->pre_sim) |