From c1ce4ba5021a9730c00bab6f8122702deb69d37e Mon Sep 17 00:00:00 2001 From: Zheyu Ma Date: Tue, 10 May 2022 23:32:46 +0800 Subject: ASoC: cs42l46: Fix the error handling of cs42l56_i2c_probe() The driver should goto label 'err_enable' when failing at regmap_read(). Signed-off-by: Zheyu Ma Link: https://lore.kernel.org/r/20220510153251.1741210-2-zheyuma97@gmail.com Signed-off-by: Mark Brown --- sound/soc/codecs/cs42l56.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sound/soc/codecs') diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c index 2c4e09b43199..dc23007336c5 100644 --- a/sound/soc/codecs/cs42l56.c +++ b/sound/soc/codecs/cs42l56.c @@ -1245,7 +1245,7 @@ static int cs42l56_i2c_probe(struct i2c_client *i2c_client) ret = regmap_read(cs42l56->regmap, CS42L56_CHIP_ID_1, ®); if (ret) { dev_err(&i2c_client->dev, "Failed to read chip ID: %d\n", ret); - return ret; + goto err_enable; } devid = reg & CS42L56_CHIP_ID_MASK; -- cgit v1.2.3