From e122eaf69422e5d9ce93fc9786099098e3b9e1c4 Mon Sep 17 00:00:00 2001 From: Haavard Skinnemoen Date: Wed, 20 Jun 2007 15:29:15 +0200 Subject: [AVR32] Remove optimization of unaligned word loads If we let unaligned word loads bypass the generic unaligned handling, gcc may combine it with a swap.b instruction and turn it into a ldwsp instruction, which does not work with unaligned addresses. Revert the optimization to prevent the RNDIS driver from crashing. Hopefully we'll figure something out later (it may be better to do the optimization in gcc.) Signed-off-by: Haavard Skinnemoen --- include/asm-avr32/unaligned.h | 26 +++----------------------- 1 file changed, 3 insertions(+), 23 deletions(-) (limited to 'include/asm-avr32') diff --git a/include/asm-avr32/unaligned.h b/include/asm-avr32/unaligned.h index 791361786fcc..36f5fd430543 100644 --- a/include/asm-avr32/unaligned.h +++ b/include/asm-avr32/unaligned.h @@ -6,31 +6,11 @@ * implementation. The AVR32 AP implementation can handle unaligned * words, but halfwords must be halfword-aligned, and doublewords must * be word-aligned. + * + * However, swapped word loads must be word-aligned so we can't + * optimize word loads in general. */ #include -#ifdef CONFIG_CPU_AT32AP7000 - -/* REVISIT calling memmove() may be smaller for 64-bit values ... */ - -#undef get_unaligned -#define get_unaligned(ptr) \ - ___get_unaligned(ptr, sizeof((*ptr))) -#define ___get_unaligned(ptr, size) \ - ((size == 4) ? *(ptr) : __get_unaligned(ptr, size)) - -#undef put_unaligned -#define put_unaligned(val, ptr) \ - ___put_unaligned((__u64)(val), ptr, sizeof((*ptr))) -#define ___put_unaligned(val, ptr, size) \ -do { \ - if (size == 4) \ - *(ptr) = (val); \ - else \ - __put_unaligned(val, ptr, size); \ -} while (0) - -#endif - #endif /* __ASM_AVR32_UNALIGNED_H */ -- cgit v1.2.3