From e34e6f8133b8c783a44c235b843e9046e55adbf0 Mon Sep 17 00:00:00 2001 From: Tim Gardner Date: Mon, 20 Sep 2021 13:05:18 -0600 Subject: gfs2: Fix unused value warning in do_gfs2_set_flags() Coverity complains of an unused value: CID 119623 (#1 of 1): Unused value (UNUSED_VALUE) assigned_value: Assigning value -1 to error here, but that stored value is overwritten before it can be used. 237 error = -EPERM; Fix it by removing the assignment. Signed-off-by: Tim Gardner Signed-off-by: Andreas Gruenbacher --- fs/gfs2/file.c | 1 - 1 file changed, 1 deletion(-) (limited to 'fs/gfs2') diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index 0f54d870e402..8267ab9b57de 100644 --- a/fs/gfs2/file.c +++ b/fs/gfs2/file.c @@ -234,7 +234,6 @@ static int do_gfs2_set_flags(struct inode *inode, u32 reqflags, u32 mask) if ((new_flags ^ flags) == 0) goto out; - error = -EPERM; if (!IS_IMMUTABLE(inode)) { error = gfs2_permission(&init_user_ns, inode, MAY_WRITE); if (error) -- cgit v1.2.3