From 30119059703f94e9e4936477bc33e918fb41e9c8 Mon Sep 17 00:00:00 2001 From: "xypron.glpk@gmx.de" Date: Wed, 18 May 2016 00:06:02 +0200 Subject: net: irda: avoid null pointer dereference Only dereference variable self after checking it is not NULL. Signed-off-by: Heinrich Schuchardt Signed-off-by: David S. Miller --- drivers/net/irda/nsc-ircc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'drivers') diff --git a/drivers/net/irda/nsc-ircc.c b/drivers/net/irda/nsc-ircc.c index 9ef13d8ed813..aaecc3baaf30 100644 --- a/drivers/net/irda/nsc-ircc.c +++ b/drivers/net/irda/nsc-ircc.c @@ -1253,7 +1253,7 @@ static void nsc_ircc_change_dongle_speed(int iobase, int speed, int dongle_id) */ static __u8 nsc_ircc_change_speed(struct nsc_ircc_cb *self, __u32 speed) { - struct net_device *dev = self->netdev; + struct net_device *dev; __u8 mcr = MCR_SIR; int iobase; __u8 bank; @@ -1263,6 +1263,7 @@ static __u8 nsc_ircc_change_speed(struct nsc_ircc_cb *self, __u32 speed) IRDA_ASSERT(self != NULL, return 0;); + dev = self->netdev; iobase = self->io.fir_base; /* Update accounting for new speed */ -- cgit v1.2.3