From e9f7be0c4316a0ea1c47b1e800baa58fb937096c Mon Sep 17 00:00:00 2001 From: Quinn Tran Date: Tue, 7 Aug 2018 20:39:52 -0700 Subject: scsi: qla2xxx: Fix issue reported by static checker for qla2x00_els_dcmd2_sp_done() This patch fixes following Smatch complaint: drivers/scsi/qla2xxx/qla_iocb.c:2647 qla2x00_els_dcmd2_sp_done() error: we previously assumed 'e' could be null (see line 2631) Fixes: 8777e4314d39 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine") Reported-by: Dan Carpenter Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Signed-off-by: Martin K. Petersen --- drivers/scsi/qla2xxx/qla_iocb.c | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/scsi') diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 059f2c9dc192..213321295753 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -2642,6 +2642,7 @@ qla2x00_els_dcmd2_sp_done(void *ptr, int res) elsio->u.els_plogi.els_resp_pyld, elsio->u.els_plogi.els_resp_pyld_dma); sp->free(sp); + return; } e->u.iosb.sp = sp; qla2x00_post_work(vha, e); -- cgit v1.2.3