From c867b55eb4831a493631205f2744b2e77ce0983b Mon Sep 17 00:00:00 2001 From: Joachim Eastwood Date: Fri, 16 Nov 2012 04:47:15 +0000 Subject: net/ethernet: remove useless is_valid_ether_addr from drivers ndo_open If ndo_validate_addr is set to the generic eth_validate_addr function there is no point in calling is_valid_ether_addr from driver ndo_open if ndo_open is not used elsewhere in the driver. With this change is_valid_ether_addr will be called from the generic eth_validate_addr function. So there should be no change in the actual behavior. Signed-off-by: Joachim Eastwood Signed-off-by: David S. Miller --- drivers/net/ethernet/wiznet/w5100.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'drivers/net/ethernet/wiznet/w5100.c') diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c index 2c08bf6e7bf3..7daf92e56b65 100644 --- a/drivers/net/ethernet/wiznet/w5100.c +++ b/drivers/net/ethernet/wiznet/w5100.c @@ -580,8 +580,6 @@ static int w5100_open(struct net_device *ndev) struct w5100_priv *priv = netdev_priv(ndev); netif_info(priv, ifup, ndev, "enabling\n"); - if (!is_valid_ether_addr(ndev->dev_addr)) - return -EINVAL; w5100_hw_start(priv); napi_enable(&priv->napi); netif_start_queue(ndev); -- cgit v1.2.3