From f2d697604cc860a177b793f669b22ef9c13131b9 Mon Sep 17 00:00:00 2001
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 25 Jan 2017 14:09:52 +0000
Subject: eeprom: idt_89hpesx: Drop kfree for memory allocated with
devm_kzalloc
It's not necessary to free memory allocated with devm_kzalloc
and using kfree leads to a double free.
Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/misc/eeprom/idt_89hpesx.c | 4 ----
1 file changed, 4 deletions(-)
(limited to 'drivers/misc/eeprom')
diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
index 5d48aecbe208..4a22a1d99395 100644
--- a/drivers/misc/eeprom/idt_89hpesx.c
+++ b/drivers/misc/eeprom/idt_89hpesx.c
@@ -1358,7 +1358,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
pdev->ee_file->size = pdev->eesize;
ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
if (ret != 0) {
- kfree(pdev->ee_file);
dev_err(dev, "Failed to create EEPROM sysfs-node");
return ret;
}
@@ -1380,9 +1379,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
/* Remove EEPROM sysfs file */
sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
-
- /* Free memory allocated for bin_attribute structure */
- kfree(pdev->ee_file);
}
/*
--
cgit v1.2.3