From f098a045350ecd6045f2f2d5a50fecf2a98962d7 Mon Sep 17 00:00:00 2001 From: Geliang Tang <geliangtang@163.com> Date: Thu, 1 Oct 2015 22:35:21 +0800 Subject: hsi: fix double kfree When device_register() fails, kfree() is called in hsi_client_release(), hence there is no need to call kfree in err3 again. Fixes: a2aa24734d9db ("HSI: Add common DT binding for HSI client devices") Signed-off-by: Geliang Tang <geliangtang@163.com> Signed-off-by: Sebastian Reichel <sre@kernel.org> --- drivers/hsi/hsi.c | 1 - 1 file changed, 1 deletion(-) (limited to 'drivers/hsi/hsi.c') diff --git a/drivers/hsi/hsi.c b/drivers/hsi/hsi.c index fe9371271ce2..35d631e91908 100644 --- a/drivers/hsi/hsi.c +++ b/drivers/hsi/hsi.c @@ -300,7 +300,6 @@ static void hsi_add_client_from_dt(struct hsi_port *port, if (device_register(&cl->device) < 0) { pr_err("hsi: failed to register client: %s\n", name); put_device(&cl->device); - goto err3; } return; -- cgit v1.2.3