From 9d42a4d3e27db3cabad82483ed876d4c8b8bed65 Mon Sep 17 00:00:00 2001 From: Vasily Gorbik Date: Fri, 9 Apr 2021 00:31:47 +0200 Subject: s390/test_unwind: add WARN if tests failed Trigger a warning if any of unwinder tests fail. This should help to prevent quiet ignoring of test results when panic_on_warn is enabled. Signed-off-by: Vasily Gorbik Signed-off-by: Heiko Carstens --- arch/s390/lib/test_unwind.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'arch') diff --git a/arch/s390/lib/test_unwind.c b/arch/s390/lib/test_unwind.c index 54b36e71ddf3..eda72bc49c79 100644 --- a/arch/s390/lib/test_unwind.c +++ b/arch/s390/lib/test_unwind.c @@ -296,16 +296,18 @@ static int test_unwind_flags(int flags) static int test_unwind_init(void) { - int ret = 0; + int failed = 0; + int total = 0; #define TEST(flags) \ do { \ pr_info("[ RUN ] " #flags "\n"); \ + total++; \ if (!test_unwind_flags((flags))) { \ pr_info("[ OK ] " #flags "\n"); \ } else { \ pr_err("[ FAILED ] " #flags "\n"); \ - ret = -EINVAL; \ + failed++; \ } \ } while (0) @@ -336,7 +338,8 @@ do { \ #endif #undef TEST - return ret; + WARN(failed, "%d of %d unwinder tests failed", failed, total); + return failed ? -EINVAL : 0; } static void test_unwind_exit(void) -- cgit v1.2.3