From ac9c41d5a053e71777e8c2191681358499eff04b Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 8 Jan 2020 08:42:36 +0300 Subject: ethtool: potential NULL dereference in strset_prepare_data() Smatch complains that the NULL checking isn't done consistently: net/ethtool/strset.c:253 strset_prepare_data() error: we previously assumed 'dev' could be null (see line 233) It looks like there is a missing return on this path. Fixes: 71921690f974 ("ethtool: provide string sets with STRSET_GET request") Signed-off-by: Dan Carpenter Reviewed-by: Michal Kubecek Signed-off-by: David S. Miller --- net/ethtool/strset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ethtool/strset.c b/net/ethtool/strset.c index 9f2243329015..82a059c13c1c 100644 --- a/net/ethtool/strset.c +++ b/net/ethtool/strset.c @@ -239,6 +239,7 @@ static int strset_prepare_data(const struct ethnl_req_info *req_base, return -EINVAL; } } + return 0; } ret = ethnl_ops_begin(dev); -- cgit v1.2.3