diff options
author | Pingfan Liu <kernelfans@gmail.com> | 2018-07-19 13:14:58 +0800 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-07-21 09:51:44 +0200 |
commit | 3297c8fc65af5d40501ea7cddff1b195cae57e4e (patch) | |
tree | bb4fe13f55f81955b1dcedc61ab1c1cb2cd510bc /tools | |
parent | 726e41097920a73e4c7c33385dcc0debb1281e18 (diff) | |
download | linux-3297c8fc65af5d40501ea7cddff1b195cae57e4e.tar.bz2 |
drivers/base: stop new probing during shutdown
There is a race window in device_shutdown(), which may cause
-1. parent device shut down before child or
-2. no shutdown on a new probing device.
For 1st, taking the following scenario:
device_shutdown new plugin device
list_del_init(parent_dev);
spin_unlock(list_lock);
device_add(child)
probe child
shutdown parent_dev
--> now child is on the tail of devices_kset
For 2nd, taking the following scenario:
device_shutdown new plugin device
device_add(dev)
device_lock(dev);
...
device_unlock(dev);
probe dev
--> now, the new occurred dev has no opportunity to shutdown
To fix this race issue, just prevent the new probing request. With this
logic, device_shutdown() is more similar to dpm_prepare().
Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
Reviewed-by: Rafael J. Wysocki <rafael@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions