diff options
| author | Patrick McHardy <kaber@trash.net> | 2009-04-15 12:45:08 +0200 |
|---|---|---|
| committer | Patrick McHardy <kaber@trash.net> | 2009-04-15 12:45:08 +0200 |
| commit | 38fb0afcd8761f8858e27135ed89a65117e2019c (patch) | |
| tree | 201b72f3173b44e4f62945d634bf1b87d80b4ad9 /net | |
| parent | b6f0a3652ea9d2296fdc98c3b2c96603be611c4d (diff) | |
| download | linux-38fb0afcd8761f8858e27135ed89a65117e2019c.tar.bz2 | |
netfilter: nf_conntrack: fix crash when unloading helpers
Commit ea781f197d (netfilter: nf_conntrack: use SLAB_DESTROY_BY_RCU and)
get rid of call_rcu() was missing one conversion to the hlist_nulls
functions, causing a crash when unloading conntrack helper modules.
Reported-and-tested-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/netfilter/nf_conntrack_helper.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nf_conntrack_helper.c b/net/netfilter/nf_conntrack_helper.c index 30b8e9009f99..0fa5a422959f 100644 --- a/net/netfilter/nf_conntrack_helper.c +++ b/net/netfilter/nf_conntrack_helper.c @@ -176,7 +176,7 @@ static void __nf_conntrack_helper_unregister(struct nf_conntrack_helper *me, } /* Get rid of expecteds, set helpers to NULL. */ - hlist_for_each_entry(h, nn, &net->ct.unconfirmed, hnnode) + hlist_nulls_for_each_entry(h, nn, &net->ct.unconfirmed, hnnode) unhelp(h, me); for (i = 0; i < nf_conntrack_htable_size; i++) { hlist_nulls_for_each_entry(h, nn, &net->ct.hash[i], hnnode) |