diff options
author | Colin Ian King <colin.king@canonical.com> | 2018-11-01 13:14:30 +0000 |
---|---|---|
committer | Steve French <stfrench@microsoft.com> | 2018-11-02 14:09:42 -0500 |
commit | 8c6c9bed8773375b1d54ccca2911ec892c59db5d (patch) | |
tree | c45857d15024dc656dc7a20fb0e75ec46b2f85b8 /net/nsh | |
parent | be4eb68846dc4450a9a4998d7c16d9f4955f9988 (diff) | |
download | linux-8c6c9bed8773375b1d54ccca2911ec892c59db5d.tar.bz2 |
cifs: don't dereference smb_file_target before null check
There is a null check on dst_file->private data which suggests
it can be potentially null. However, before this check, pointer
smb_file_target is derived from dst_file->private and dereferenced
in the call to tlink_tcon, hence there is a potential null pointer
deference.
Fix this by assigning smb_file_target and target_tcon after the
null pointer sanity checks.
Detected by CoverityScan, CID#1475302 ("Dereference before null check")
Fixes: 04b38d601239 ("vfs: pull btrfs clone API to vfs layer")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'net/nsh')
0 files changed, 0 insertions, 0 deletions