diff options
| author | Geliang Tang <geliangtang@gmail.com> | 2017-05-06 23:42:22 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-05-08 15:02:10 -0400 |
| commit | 871ff2ebe0af0d7f1050bfc8bce62fddea2b12ec (patch) | |
| tree | 2a1ad5d19e8c0902c8d265d4ff05afce75fe8a50 /drivers | |
| parent | 294316a4af16cd5c355a80bd2dc7ea803b88f6ba (diff) | |
| download | linux-871ff2ebe0af0d7f1050bfc8bce62fddea2b12ec.tar.bz2 | |
yam: use memdup_user
Use memdup_user() helper instead of open-coding to simplify the code.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/hamradio/yam.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index b6891ada1d7b..7a7c5224a336 100644 --- a/drivers/net/hamradio/yam.c +++ b/drivers/net/hamradio/yam.c @@ -976,12 +976,10 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) case SIOCYAMSMCS: if (netif_running(dev)) return -EINVAL; /* Cannot change this parameter when up */ - if ((ym = kmalloc(sizeof(struct yamdrv_ioctl_mcs), GFP_KERNEL)) == NULL) - return -ENOBUFS; - if (copy_from_user(ym, ifr->ifr_data, sizeof(struct yamdrv_ioctl_mcs))) { - kfree(ym); - return -EFAULT; - } + ym = memdup_user(ifr->ifr_data, + sizeof(struct yamdrv_ioctl_mcs)); + if (IS_ERR(ym)) + return PTR_ERR(ym); if (ym->bitrate > YAM_MAXBITRATE) { kfree(ym); return -EINVAL; |