diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-01-08 09:36:01 -0600 |
|---|---|---|
| committer | Boris Brezillon <bbrezillon@kernel.org> | 2019-01-15 20:49:29 +0100 |
| commit | 9cb76a6aa1a9524866ec1558f08d044506b707fa (patch) | |
| tree | d58ef13f7262e7ca22d11077856c88e307f3f671 /drivers | |
| parent | f9d27de6fafce7b50a6ca6a7696f3d62aee6808e (diff) | |
| download | linux-9cb76a6aa1a9524866ec1558f08d044506b707fa.tar.bz2 | |
mtd: gen_probe: Use struct_size() in kmalloc()
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:
struct foo {
int stuff;
void *entry[];
};
instance = kmalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:
instance = kmalloc(struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Boris Brezillon <bbrezillon@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mtd/chips/gen_probe.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/chips/gen_probe.c b/drivers/mtd/chips/gen_probe.c index 837b04ab96a9..839ed40625d6 100644 --- a/drivers/mtd/chips/gen_probe.c +++ b/drivers/mtd/chips/gen_probe.c @@ -135,7 +135,7 @@ static struct cfi_private *genprobe_ident_chips(struct map_info *map, struct chi * our caller, and copy the appropriate data into them. */ - retcfi = kmalloc(sizeof(struct cfi_private) + cfi.numchips * sizeof(struct flchip), GFP_KERNEL); + retcfi = kmalloc(struct_size(retcfi, chips, cfi.numchips), GFP_KERNEL); if (!retcfi) { kfree(cfi.cfiq); |