diff options
| author | Rasmus Villemoes <linux@rasmusvillemoes.dk> | 2016-02-15 19:41:46 +0100 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2016-02-19 13:36:05 +1000 |
| commit | 4fbbed46dca83bcba3a0170205110a06c116a8e6 (patch) | |
| tree | 446e525b609222a41fb398993131b9a5d25e1abd /drivers | |
| parent | 5fff80bbdb6b84a94f90391ba674471d37b57eb2 (diff) | |
| download | linux-4fbbed46dca83bcba3a0170205110a06c116a8e6.tar.bz2 | |
drm/nouveau: use post-decrement in error handling
We need to use post-decrement to get the dma_map_page undone also for
i==0, and to avoid some very unpleasant behaviour if dma_map_page
failed already at i==0.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/gpu/drm/nouveau/nouveau_bo.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 78f520d05de9..e3acc35e3805 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bo.c +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c @@ -1520,7 +1520,7 @@ nouveau_ttm_tt_populate(struct ttm_tt *ttm) DMA_BIDIRECTIONAL); if (dma_mapping_error(pdev, addr)) { - while (--i) { + while (i--) { dma_unmap_page(pdev, ttm_dma->dma_address[i], PAGE_SIZE, DMA_BIDIRECTIONAL); ttm_dma->dma_address[i] = 0; |