diff options
| author | Bart Van Assche <bvanassche@acm.org> | 2019-08-08 20:01:47 -0700 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2019-08-12 21:34:06 -0400 |
| commit | 282d10565ee9b574c40b1233a7a666034e76aa4c (patch) | |
| tree | 2f8e4df55c47694f0589eed43fe4c041444d0c73 /drivers/scsi/qla2xxx/qla_isr.c | |
| parent | 258f0752ef363caafb0bce311369d50c87aa0b25 (diff) | |
| download | linux-282d10565ee9b574c40b1233a7a666034e76aa4c.tar.bz2 | |
scsi: qla2xxx: Simplify a debug statement
Read the FC port state once instead of twice. This patch fixes the
following Coverity complaint:
Unchecked return value (CHECKED_RETURN)
check_return: Calling atomic_read without checking return value (as is
done elsewhere 80 out of 92 times).
Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Tested-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/qla2xxx/qla_isr.c')
| -rw-r--r-- | drivers/scsi/qla2xxx/qla_isr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index e8ce57cb897e..55eb51539cb0 100644 --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -2726,7 +2726,7 @@ check_scsi_status: "Port to be marked lost on fcport=%02x%02x%02x, current " "port state= %s comp_status %x.\n", fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa, - port_state_str[atomic_read(&fcport->state)], + port_state_str[FCS_ONLINE], comp_status); qla2x00_mark_device_lost(fcport->vha, fcport, 1, 1); |