summaryrefslogtreecommitdiffstats
path: root/block/blk-rq-qos.h
diff options
context:
space:
mode:
authorMing Lei <ming.lei@redhat.com>2019-09-12 12:02:24 +0800
committerJens Axboe <axboe@kernel.dk>2019-09-12 07:13:22 -0600
commit0a67b5a926e63ff5492c3c675eab5900580d056d (patch)
tree46b1761c8dc89e466d14e20abd659a3e76a1ca24 /block/blk-rq-qos.h
parentb804049dce9128a88558bc1594ff96d6632fbc10 (diff)
downloadlinux-0a67b5a926e63ff5492c3c675eab5900580d056d.tar.bz2
block: fix race between switching elevator and removing queues
cecf5d87ff20 ("block: split .sysfs_lock into two locks") starts to release & actuire sysfs_lock again during switching elevator. So it isn't enough to prevent switching elevator from happening by simply clearing QUEUE_FLAG_REGISTERED with holding sysfs_lock, because in-progress switch still can move on after re-acquiring the lock, meantime the flag of QUEUE_FLAG_REGISTERED won't get checked. Fixes this issue by checking 'q->elevator' directly & locklessly after q->kobj is removed in blk_unregister_queue(), this way is safe because q->elevator can't be changed at that time. Fixes: cecf5d87ff20 ("block: split .sysfs_lock into two locks") Cc: Christoph Hellwig <hch@infradead.org> Cc: Hannes Reinecke <hare@suse.com> Cc: Greg KH <gregkh@linuxfoundation.org> Cc: Mike Snitzer <snitzer@redhat.com> Cc: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Ming Lei <ming.lei@redhat.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-rq-qos.h')
0 files changed, 0 insertions, 0 deletions