diff options
author | Dmitry V. Levin <ldv@altlinux.org> | 2019-02-16 16:10:39 +0300 |
---|---|---|
committer | Helge Deller <deller@gmx.de> | 2019-02-21 20:10:46 +0100 |
commit | b7dc5a071ddf69c0350396b203cba32fe5bab510 (patch) | |
tree | bd5b70d0de029450d878f044c5df9b2921f3ea08 /CREDITS | |
parent | f6163d67cc31b8f2a946c4df82be3c6dd918412d (diff) | |
download | linux-b7dc5a071ddf69c0350396b203cba32fe5bab510.tar.bz2 |
parisc: Fix ptrace syscall number modification
Commit 910cd32e552e ("parisc: Fix and enable seccomp filter support")
introduced a regression in ptrace-based syscall tampering: when tracer
changes syscall number to -1, the kernel fails to initialize %r28 with
-ENOSYS and subsequently fails to return the error code of the failed
syscall to userspace.
This erroneous behaviour could be observed with a simple strace syscall
fault injection command which is expected to print something like this:
$ strace -a0 -ewrite -einject=write:error=enospc echo hello
write(1, "hello\n", 6) = -1 ENOSPC (No space left on device) (INJECTED)
write(2, "echo: ", 6) = -1 ENOSPC (No space left on device) (INJECTED)
write(2, "write error", 11) = -1 ENOSPC (No space left on device) (INJECTED)
write(2, "\n", 1) = -1 ENOSPC (No space left on device) (INJECTED)
+++ exited with 1 +++
After commit 910cd32e552ea09caa89cdbe328e468979b030dd it loops printing
something like this instead:
write(1, "hello\n", 6../strace: Failed to tamper with process 12345: unexpectedly got no error (return value 0, error 0)
) = 0 (INJECTED)
This bug was found by strace test suite.
Fixes: 910cd32e552e ("parisc: Fix and enable seccomp filter support")
Cc: stable@vger.kernel.org # v4.5+
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Tested-by: Helge Deller <deller@gmx.de>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'CREDITS')
0 files changed, 0 insertions, 0 deletions