linux/drivers/ata/ata_piix.c, branch v2.6.28

ATA: piix, fix pointer deref on suspend

2008-12-09T05:43:54Z

Hi, I've found this issue in the mmotm 2008-12-02-17-08. -- Commit ata_piix: add borked Tecra M4 to broken suspend list introduced DMI variables checking, but they can be null, so that we possibly dereference null. Check if they are null and avoid checks in that case. Solves: BUG: unable to handle kernel NULL pointer dereference at 0000000000000000 IP: [] piix_pci_device_suspend+0x117/0x230 Signed-off-by: Jiri Slaby Cc: Jeff Garzik Cc: Alexandru Romanescu Cc: Tejun Heo Signed-off-by: Jeff Garzik

ata_piix: add borked Tecra M4 to broken suspend list

2008-12-01T18:48:45Z

Tecra M4 sometimes forget what it is and reports bogus data via DMI which makes the machine evade broken suspend matching and thus fail suspend/resume. This patch updates piix_broken_suspend() such that it can match such case. As the borked DMI data is a bit generic, matching many entries to make the match more specific is necessary. As the usual DMI matching is limited to four entries, this patch uses hard coded manual matching. This is reported by Alexandru Romanescu. Signed-off-by: Tejun Heo Cc: Alexandru Romanescu Signed-off-by: Jeff Garzik

ATA: remove excess kernel-doc notation

2008-10-31T05:42:49Z

Remove excess kernel-doc function parameter notation from drivers/ata/: Warning(drivers/ata/libata-core.c:1622): Excess function parameter or struct member 'fn' description in 'ata_pio_queue_task' Warning(drivers/ata/libata-core.c:4655): Excess function parameter or struct member 'err_mask' description in 'ata_qc_complete' Warning(drivers/ata/ata_piix.c:751): Excess function parameter or struct member 'udma' description in 'do_pata_set_dmamode' Signed-off-by: Randy Dunlap Signed-off-by: Jeff Garzik

ata: Switch all my stuff to a common address

2008-10-28T03:54:50Z

Signed-off-by: Jeff Garzik

ata_piix: IDE Mode SATA patch for Intel Ibex Peak DeviceIDs

2008-09-29T04:29:12Z

This patch updates the Intel Ibex Peak (PCH) IDE mode SATA Controller DeviceIDs. Signed-off-by: Seth Heasley Signed-off-by: Jeff Garzik

ata_piix: add Hercules EC-900 mini-notebook to ich_laptop short cable list

2008-09-29T04:28:40Z

Signed-off-by: Herton Ronaldo Krzesinski Signed-off-by: Jeff Garzik

ata_piix: drop merged SCR access and use slave_link instead

2008-09-29T04:25:32Z

Now that libata has slave_link, there's no need to keep ugly merged SCR access. Drop it and use slave_link instead. This results in simpler code and much better separate link handling for master and slave. Signed-off-by: Tejun Heo Signed-off-by: Jeff Garzik

libata: make SCR access ops per-link

2008-09-29T04:22:28Z

Logically, SCR access ops should take @link; however, there was no compelling reason to convert all SCR access ops when adding @link abstraction as there's one-to-one mapping between a port and a non-PMP link. However, that assumption won't hold anymore with the scheduled addition of slave link. Make SCR access ops per-link. Signed-off-by: Tejun Heo Signed-off-by: Jeff Garzik

ata: duplicate variable sparse warning

2008-09-13T20:43:18Z

drivers/ata/ata_piix.c:1502:7: warning: symbol 'rc' shadows an earlier one Signed-off-by: Stephen Hemminger Signed-off-by: Jeff Garzik

ata_piix: IDE Mode SATA patch for Intel Ibex Peak DeviceIDs

2008-08-22T06:08:04Z

This patch adds the Intel Ibex Peak (PCH) IDE mode SATA Controller DeviceIDs. Signed-off-by: Seth Heasley Signed-off-by: Jeff Garzik