From dfc021d7c416b47576631016ac931271318df268 Mon Sep 17 00:00:00 2001 From: Pali Rohár Date: Mon, 29 Sep 2014 00:43:15 +0200 Subject: image: Fix memory leaks --- src/image.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/image.c b/src/image.c index 44655fb..48d80d8 100644 --- a/src/image.c +++ b/src/image.c @@ -88,14 +88,13 @@ static void image_missing_values_from_name(struct image * image, const char * na if ( image->devices && image->devices->device && ! image->devices->hwrevs ) image->devices->hwrevs = hwrevs_alloc_from_string(hwrevs); - else - free(hwrevs); if ( ! image->version ) image->version = version; else free(version); + free(hwrevs); free(str); } @@ -135,8 +134,10 @@ char * image_name_alloc_from_values(struct image * image) { length += 1 + strlen(image->version); name = calloc(1, length); - if ( ! name ) + if ( ! name ) { + free(hwrevs); ALLOC_ERROR_RETURN(NULL); + } strcpy(name, type); ptr = name + strlen(name); -- cgit v1.2.3